Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan for triaging semver-minor backports in LTS meetings #204

Closed
gibfahn opened this issue Apr 24, 2017 · 2 comments
Closed

Plan for triaging semver-minor backports in LTS meetings #204

gibfahn opened this issue Apr 24, 2017 · 2 comments

Comments

@gibfahn
Copy link
Member

gibfahn commented Apr 24, 2017

I'm not sure what the existing process is, but given the discussions around backporting and labelling (nodejs/node#12431), it might be worth trying to decide how we're going to triage semver-minor backport PRs.

Obviously this doesn't have to be set in stone, and it's more a note to self than anything else. If things are obviously wrong feel free to just edit this directly.

Strawman proposal:

Run branch-diff -g --filter-release --require-label=semver-minor --exclude-label=semver-major,meta,dont-land-on-v6.x,backport-requested-to-v6.x upstream/v6.10.3-proposal upstream/v7.x

For each PR we:

  • add do-not-land-v6.x if we think it should not be backported (with a comment)
  • add land-on-v6.x if we think it should be backported (will be replaced with cherry-picked-to-v6.x or backported-to-v6.x)
  • leave lts-watch-v6.x if we want to leave it to bake for a while, and revisit later.
@jasnell
Copy link
Member

jasnell commented Apr 24, 2017

to this point, the process has been to wait until we have a batch of semver-minor commits queued up, then we go through them to make sure there are no objections. Generally speaking, we've only backported semver-minor's into LTS on request -- that is, we only backport if there is a specific request to do so. I've seen nothing to convince me that that process should be changed. Going through all of the potential semver-minor's that could land is not a great use of time.

@gibfahn gibfahn removed the lts-agenda label Jun 5, 2017
@gibfahn
Copy link
Member Author

gibfahn commented Jun 14, 2017

Agreed at meetings, note that we have the baking-for-lts label now to cover things that are baking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants