Always send 'dialog-dismissed' when clicking outside the dialog #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you confirmed the dialog first, then reopened it and canceled it by clicking outside, the 'dialog-confirmed' message would be send again.
This was referenced Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open a dialog and then click the confirm button.
Then reopen that dialog, but this time cancel it by clicking outside.
Then the
dialog-confirmedmessage is send.In my case I want to do a destructive operation on confirmation, so clicking outside should imho always result in dismissing the dialog.
This is due to setting the
When clicking the dialog-confirm button
closingReasonConfirmedof the dialog is set totrue(https://github.com/nodecg/nodecg/blob/master/src/dashboard/js/dialog_helper.js#L17) but not reset once the dialog is opened again.My proposed fix is to test that the dialog is not canceled before send the
dialog-confirmedevent.