Merge pull request #24 from node-red/eslint-func-fixes

Run eslint on all parts of Function node and handle built-ins

Author: knolleary

lib/rules/function-eslint/function-eslint.js

@@ -69,6 +69,30 @@ var defaultConfig = {
     }
 }
 
+function lintCode(config, property) {
+    var code = "const RED = {}; // eslint-disable-line\n"+
+        "const context = {}; // eslint-disable-line\n"+
+        "const global = {}; // eslint-disable-line\n"+
+        "const flow = {}; // eslint-disable-line\n"+
+        "const env = {}; // eslint-disable-line\n"+
+        "const __msgid__ = {}; // eslint-disable-line\n"+
+        "const node = {}; // eslint-disable-line\n"+
+        "(async function(msg,__send__,__done__){ // eslint-disable-line\n"+
+        property+
+        "}); // eslint-disable-line";
+    return linter.verify(code, config);
+}
+
+function reportResults(context, node, results, location) {
+    results.forEach(function(r) {
+        context.report({
+            location: [node.id],
+            message: "["+location+"] "+r.message,
+            severity: (r.severity == 1)? "warn" : "error",
+            additionalInfo: r
+        })
+    });
+}
 module.exports = {
     meta: {
         type: "suggestion",
@@ -86,23 +110,14 @@ module.exports = {
         var config = ruleConfig.config || defaultConfig;
         return {
             "type:function": function(node) {
-                // TODO: lint the on-start / on-close code
-                var code = "(async function(msg,__send__,__done__){"+
-                    "var __msgid__;"+
-                    "var node; // eslint-disable-line\n"+
-                    node.config.func+"\n"+
-                    "}); // eslint-disable-line";
-                var result = linter.verify(code, config);
-                result.forEach(function(r) {
-                    // console.log(r);
-                    context.report({
-                        location: [node.id],
-                        message: r.message,
-                        severity: (r.severity == 1)? "warn" : "error",
-                        additionalInfo: r
-                    })
-                    // console.log(r);
-                });
+                reportResults(context,node,lintCode(config,node.config.func),"msg");
+                if (node.config.initialize) {
+                    reportResults(context,node,lintCode(config,node.config.initialize),"start");
+                }
+                if (node.config.finalize) {
+                    reportResults(context,node,lintCode(config,node.config.finalize),"stop");
+                }
+
             }
         }
     }