Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import fixes from https://github.com/Contrast-Security-Inc/esprima #6

Closed
26 tasks done
jogibear9988 opened this issue Jun 15, 2021 · 5 comments
Closed
26 tasks done

Comments

@jogibear9988
Copy link
Member

jogibear9988 commented Jun 15, 2021

https://github.com/Contrast-Security-Inc/esprima has many fixes not in our fork, look for them.

jquery/esprima@main...Contrast-Security-Inc:master

  • backport old javascript patches into typescript
  • add parser support for optional try / catch binding as seen in TC39/t… …
  • adjust node type for catchclause to support null arguments for non-as… …
  • add associated test
  • var -> let
  • add es6 flag because TS continuous integration will fail otherwise (e… …
  • update whitelist
  • Merge remote-tracking branch 'origin/master' into NODE-957
  • remove deceptive jsdoc and fix function to adhere
  • Merge pull request #1 from Contrast-Security-Inc/NODE-957 …
  • move to @contrast/esprima
  • Merge branch 'master' of github.com:contrast-security-inc/esprima int… …
  • update package.json to use 4.0 tag
  • add optional chaining support
  • fix indentation
  • add parsing support for nullish coalescing
  • fix indentation
  • Merge pull request I'd like to join #2 from Contrast-Security-Inc/optional-chaining …
  • 4.1.0
  • fixed issue with optional chaining conflating decimal numbers in a …
  • undid tab
  • Merge branch 'hotfix/NODE-1126-fix-nullish-coalesce'
  • remove unnecessary dependencies and audit fix all but one low severit… …
  • Merge pull request Fix Code Styling and Eslint Checks #4 from Contrast-Security-Inc/NODE-1546-bump …
  • 4.1.1
  • 4.1.2
@jogibear9988
Copy link
Member Author

about this commit:

backport old javascript patches into typescript

is this valid? I did not find classproperty in estree specification

@jogibear9988
Copy link
Member Author

@Meir017
Copy link
Collaborator

Meir017 commented Jun 15, 2021

maybe in Es2022 https://github.com/estree/estree/blob/master/es2022.md

chrome already support private members
image

class IncreasingCounter {
  #count = 0;
  get value() {
    console.log('Getting the current value!');
    return this.#count;
  }
  increment() {
    this.#count++;
  }
}

@jogibear9988
Copy link
Member Author

jogibear9988 commented Jun 15, 2021

Yes, but the name of the interface/class in estree spec is PropertyDefinition

@jogibear9988
Copy link
Member Author

everything from this fork is in esprima-next, but maybe in other form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants