Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should double check 0.0.0.0 and localhost #20

Merged
merged 2 commits into from
May 11, 2017
Merged

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented May 11, 2017

@fengmk2 fengmk2 added the bug label May 11, 2017
@mention-bot
Copy link

@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @xudafeng to be a potential reviewer.

@codecov
Copy link

codecov bot commented May 11, 2017

Codecov Report

Merging #20 into master will decrease coverage by 0.4%.
The diff coverage is 91.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   94.28%   93.87%   -0.41%     
==========================================
  Files           2        2              
  Lines          35       49      +14     
==========================================
+ Hits           33       46      +13     
- Misses          2        3       +1
Impacted Files Coverage Δ
lib/detect-port.js 93.75% <91.3%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e852e3...9209b93. Read the comment docs.

@fengmk2 fengmk2 merged commit 0765f0e into master May 11, 2017
@fengmk2 fengmk2 deleted the detect-localhost branch May 11, 2017 03:53
@fengmk2
Copy link
Member Author

fengmk2 commented May 11, 2017

1.1.2

@Timer
Copy link

Timer commented May 11, 2017

Thanks for the super quick turn around on this, @fengmk2!

Your efforts are much appreciated. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to specify a hostname Library not detecting port is in use
3 participants