Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spock to 2.0 breaks RunWithMultipleGradleVersionsExtension #207

Closed
deepy opened this issue Jan 4, 2022 · 1 comment
Closed

Update spock to 2.0 breaks RunWithMultipleGradleVersionsExtension #207

deepy opened this issue Jan 4, 2022 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@deepy
Copy link
Member

deepy commented Jan 4, 2022

The initial change is easy, replace extends AbstractAnnotationDrivenExtension with implements IAnnotationDrivenExtension
Add testImplementation(platform("org.spockframework:spock-bom:2.0-groovy-3.0"))

and add a testImplementation("org.spockframework:spock-junit4") to make TemporaryDirectory continue working.

When running with a single version from RunWithMultipleGradleVersionsExtension this works fine, but when running with mutliple versions the following happens after the tests finish:

java.util.NoSuchElementException
	at java.base/java.util.LinkedList.removeFirst(LinkedList.java:274)
	at org.spockframework.mock.runtime.MockController.leaveScope(MockController.java:76)
	at com.github.gradle.node.npm.task.NpmInstall_integTest.install packages with npm(NpmInstall_integTest.groovy:39)
	Suppressed: java.util.NoSuchElementException
		... 3 more
@deepy deepy added this to the 3.3 milestone Jan 4, 2022
@deepy deepy added bug Something isn't working help wanted Extra attention is needed labels Jan 4, 2022
@deepy deepy changed the title Update spock to 2.0 Update spock to 2.0 breaks RunWithMultipleGradleVersionsExtension Jan 4, 2022
@deepy
Copy link
Member Author

deepy commented Sep 18, 2022

Switched version injection system.

@deepy deepy closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant