Skip to content

Bump IREE requirement pins to 3.8.0rc20250923#2205

Merged
amd-vivekag merged 26 commits into
mainfrom
integrates/iree
Sep 23, 2025
Merged

Bump IREE requirement pins to 3.8.0rc20250923#2205
amd-vivekag merged 26 commits into
mainfrom
integrates/iree

Conversation

@shark-pr-automator
Copy link
Copy Markdown
Contributor

@shark-pr-automator shark-pr-automator Bot commented Sep 9, 2025

Diff: iree-org/iree@iree-3.7.0rc20250828...iree-3.8.0rc20250923

Auto-generated by GitHub Actions using .github/workflows/update_iree_requirement_pins.yml.

pickup specialization microkernels for gfx950.
Refer to this IREE commit

Test result on gfx950 shows including the below compiling option when using iree-compile get better performance:
--iree-hip-enable-tensor-ukernels

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 9, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  sharktank
  conftest.py
Project Total  

This report was generated by python-coverage-comment-action

@archana-ramalingam archana-ramalingam changed the title Bump IREE requirement pins to 3.7.1 Bump IREE requirement pins to 3.8.0rc20250910 Sep 10, 2025
dezhiAmd and others added 3 commits September 12, 2025 14:07
Signed-off-by: dezhliao <dezhi.liao@amd.com>
…Perplexity[False] tests

Signed-off-by: dezhliao <dezhi.liao@amd.com>
Signed-off-by: dezhliao <dezhliao@amd.com>
@dezhiAmd
Copy link
Copy Markdown
Contributor

I am working on bump to 3.8.0rc20250909.
We need to disable a few llvm-compile-target-as-cpu.
please refer to
#2242

BTW, what fix, new feature is 3.8.0rc20250910?

dezhiAmd and others added 6 commits September 16, 2025 10:23
Signed-off-by: dezhliao <dezhi.liao@amd.com>
Signed-off-by: dezhliao <dezhi.liao@amd.com>
Signed-off-by: dezhliao <dezhliao@amd.com>
Signed-off-by: dezhliao <dezhliao@amd.com>
Signed-off-by: dezhliao <dezhi.liao@amd.com>
Signed-off-by: dezhliao <dezhi.liao@amd.com>
@amd-vivekag
Copy link
Copy Markdown
Contributor

I am working on bump to 3.8.0rc20250909. We need to disable a few llvm-compile-target-as-cpu. please refer to #2242

BTW, what fix, new feature is 3.8.0rc20250910?

Hi @dezhiAmd did you have any progress on this? Since I didn't hear from you since night, so I was also looking into it today and found that 2 more toyLlama tests started failing since following PR commit: iree-org/iree#21851

I'm adding xfail on those 2 testcases and will try to update the PR with latest IREE build.

@amd-vivekag
Copy link
Copy Markdown
Contributor

XFailed 2 toy llama testcases and filed an issue for that: iree-org/iree#22015

@amd-vivekag
Copy link
Copy Markdown
Contributor

amd-vivekag commented Sep 17, 2025

@dezhiAmd I just noticed that you have already worked upon the xfailing testcases and created issues w.r.t. following PR: #2242

I'll let you continue on that now. I'm not making any changes further. we can close this PR once your PR gets merged.

@Alex-Vasile
Copy link
Copy Markdown
Contributor

We should be doing our IREE bumps using these automated PRs. They insure we don't forget to change one of the files and they use a standardized naming scheme which makes it easy to find later.

Additionally, the automation will only run if this branch does not exist. We have done manual bumps before and forgot to delete this branch, leading to us staying on an old iree pin for weeks before realizing the issue.

@amd-vivekag
Copy link
Copy Markdown
Contributor

We should be doing our IREE bumps using these automated PRs. They insure we don't forget to change one of the files and they use a standardized naming scheme which makes it easy to find later.

Additionally, the automation will only run if this branch does not exist. We have done manual bumps before and forgot to delete this branch, leading to us staying on an old iree pin for weeks before realizing the issue.

If that is the case, then I can continue on this, and will try to merge.

@amd-vivekag
Copy link
Copy Markdown
Contributor

Somehow smoke tests are failing in CI but passing in my local run. Any suggestion what should I do locally to reproduce the issue?

@amd-vivekag amd-vivekag changed the title Bump IREE requirement pins to 3.8.0rc20250910 Bump IREE requirement pins to 3.8.0rc20250916 Sep 17, 2025
@amd-vivekag amd-vivekag changed the title Bump IREE requirement pins to 3.8.0rc20250916 Bump IREE requirement pins to 3.8.0rc20250917 Sep 17, 2025
@dezhiAmd
Copy link
Copy Markdown
Contributor

Somehow smoke tests are failing in CI but passing in my local run. Any suggestion what should I do locally to reproduce the issue?

I reproduced the issue locally. And reported the iree issue here: iree-org/iree#22026

Signed-off-by: dezhliao <dezhliao@amd.com>
@dezhiAmd
Copy link
Copy Markdown
Contributor

I am working on bump to 3.8.0rc20250909. We need to disable a few llvm-compile-target-as-cpu. please refer to #2242

BTW, what fix, new feature is 3.8.0rc20250910?

Also I am curious about the scenarios where compiling MLIR to a VMFB for a CPU target would be beneficial. From my understanding, AMD's strengths lie in GPU hardware, and AI inference workloads are typically GPU-accelerated. So I'm trying to better understand the rationale or use cases behind targeting the CPU in this context

@amd-vivekag
Copy link
Copy Markdown
Contributor

amd-vivekag commented Sep 18, 2025

We can revert changes in toy llama testcase because it has been fixed under PR: iree-org/iree#22010

@amd-vivekag
Copy link
Copy Markdown
Contributor

I am working on bump to 3.8.0rc20250909. We need to disable a few llvm-compile-target-as-cpu. please refer to #2242
BTW, what fix, new feature is 3.8.0rc20250910?

Also I am curious about the scenarios where compiling MLIR to a VMFB for a CPU target would be beneficial. From my understanding, AMD's strengths lie in GPU hardware, and AI inference workloads are typically GPU-accelerated. So I'm trying to better understand the rationale or use cases behind targeting the CPU in this context

As far as I know, this is the rationale behind supporting CPU: the complete workflow should support both CPU and GPU because there are lot of light weight models which can be run on CPU.

@dezhiAmd dezhiAmd changed the title Bump IREE requirement pins to 3.8.0rc20250916 Bump IREE requirement pins to 3.8.0rc20250918 Sep 18, 2025
@dezhiAmd
Copy link
Copy Markdown
Contributor

Failure of [CI - sharktank / Unit Tests (linux-mi325-8gpu-ossci-nod-ai, 3.12, 2.6.0) is caused by this iree issue: https://github.com/iree-org/iree/issues/22018

Comment thread .github/workflows/pkgci_shark_ai.yml Outdated
@archana-ramalingam
Copy link
Copy Markdown
Collaborator

Failure of [CI - sharktank / Unit Tests (linux-mi325-8gpu-ossci-nod-ai, 3.12, 2.6.0) is caused by this iree issue: https://github.com/iree-org/iree/issues/22018

Do we wait for this issue to be fixed or plan on xfailing and landing this for now? Preferably the latter, as long as it's only impacting toy llama.

@amd-vivekag
Copy link
Copy Markdown
Contributor

Failure of [CI - sharktank / Unit Tests (linux-mi325-8gpu-ossci-nod-ai, 3.12, 2.6.0) is caused by this iree issue: https://github.com/iree-org/iree/issues/22018

Do we wait for this issue to be fixed or plan on xfailing and landing this for now? Preferably the latter, as long as it's only impacting toy llama.

The error got changed it seems. So, I have created another issue for the same: iree-org/iree#22055
I'm not sure if xfailing the testcase is the right approach.

@rsuderman , @IanNod please share your thoughts.

Signed-off-by: dezhliao <dezhliao@amd.com>
@dezhiAmd dezhiAmd changed the title Bump IREE requirement pins to 3.8.0rc20250918 Bump IREE requirement pins to 3.8.0rc20250922 Sep 22, 2025
@amd-vivekag amd-vivekag changed the title Bump IREE requirement pins to 3.8.0rc20250922 Bump IREE requirement pins to 3.8.0rc20250923 Sep 23, 2025
@amd-vivekag amd-vivekag merged commit 17210d9 into main Sep 23, 2025
76 of 105 checks passed
@amd-vivekag amd-vivekag deleted the integrates/iree branch September 23, 2025 12:30
RattataKing pushed a commit that referenced this pull request Mar 2, 2026
Diff:
iree-org/iree@iree-3.7.0rc20250828...iree-3.8.0rc20250923

Auto-generated by GitHub Actions using
[`.github/workflows/update_iree_requirement_pins.yml`](https://github.com/nod-ai/shark-ai/blob/main/.github/workflows/update_iree_requirement_pins.yml).


pickup specialization microkernels for gfx950.
Refer to this IREE
[commit](iree-org/iree@a523efe)

Test result on gfx950 shows including the below compiling option when
using iree-compile get better performance:
--iree-hip-enable-tensor-ukernels

---------

Signed-off-by: dezhliao <dezhi.liao@amd.com>
Signed-off-by: dezhliao <dezhliao@amd.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dezhliao <dezhi.liao@amd.com>
Co-authored-by: dezhliao <dezhliao@amd.com>
Co-authored-by: shark-pr-automator[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: archana-ramalingam <archana.ramalingam@amd.com>
Co-authored-by: Archana Ramalingam <98564406+archana-ramalingam@users.noreply.github.com>
Co-authored-by: Vivek Agrawal <197589114+amd-vivekag@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants