Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lisbon Relation Issue #111

Closed
andreagroferreira opened this issue Mar 1, 2025 · 1 comment
Closed

Lisbon Relation Issue #111

andreagroferreira opened this issue Mar 1, 2025 · 1 comment

Comments

@andreagroferreira
Copy link

Describe the bug
There is an error in the relationship between the city of Lisbon and the state of Guarda. There is no such city in the District of Guarda in Portugal. The coordinates of the objects are in the direction of Lisbon.

To Reproduce
Steps to reproduce the behavior:
$city = $world->cities([
'fields' => 'state',
'filters' => [
'country_id' => 177
'name' => "Lisbon"
]
]);

Illuminate\Support\Collection {#2992
#items: array:2 [
0 => array:3 [
"id" => 92180
"name" => "Lisbon"
"state" => array:2 [
"id" => 3285
"name" => "Guarda"
] ---> is wrong
]
1 => array:3 [
"id" => 92582
"name" => "Lisbon"
"state" => array:2 [
"id" => 3287
"name" => "Lisbon"
]
]
]
}

Expected behavior
Illuminate\Support\Collection {#2992
#items: array:1 [
0 => array:3 [
"id" => 92582
"name" => "Lisbon"
"state" => array:2 [
"id" => 3287
"name" => "Lisbon"
]
]
]
}

Additional context
I did the fix in this PR #110

@nnjeim
Copy link
Owner

nnjeim commented Mar 3, 2025

@andreagroferreira the PR was merged

@nnjeim nnjeim closed this as completed Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants