Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A strange error: the sum of the seg_ph_count is one more than the number of h_ph. #16

Open
cugsunjie opened this issue Apr 14, 2024 · 2 comments

Comments

@cugsunjie
Copy link

During the test, we found a problem that sometimes the number of h_ph is not equal to the sum of the seg_ph_count for the same track, the sum of the seg_ph_count is always one more than the number of h_ph. Different length may lead to an error for dataframe construction. Is there any suggestion?

@nmt28
Copy link
Owner

nmt28 commented Apr 14, 2024

Thanks for reporting this. I have heard about this elsewhere. It likely comes from my interpolation. Until I can look into this in more detail, you can remove one photon from the end of the seg_ph_count.

If I understand correctly, this should remedy the problem until I can look at it in more detail

@nmt28
Copy link
Owner

nmt28 commented Jun 29, 2024

@petebunting - this issue was flagged here. I have contacted the IS2 team about it.

@cugsunjie - There is currently a 'hack' fix in the latest version. It aslso has some better error handling etc. There are also some enhancements around installation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants