Ran the 2to3 script on nltk_contrib/ #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in the nltk_contrib/fuf/ module.
|
@stevenbird Are you willing to accept this going straight to master? I've set up a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running the script to convert the package to python 3, I manually fixed runtime errors in the nltk_contrib/fuf/ module. So far that is the only module that I've tested, but before merging this into master, the rest of the modules should be tested as well.
I think this should be merged into a new branch (say 'python 3') so that others have easier access to a rough python 3 implementation of nltk_contrib. It will take some time to test all of the modules.