Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-fno-expection not respected anymore in 3.9.1 #2725

Closed
ingomueller-net opened this issue Apr 20, 2021 · 2 comments
Closed

-fno-expection not respected anymore in 3.9.1 #2725

ingomueller-net opened this issue Apr 20, 2021 · 2 comments
Assignees
Labels
kind: bug release item: 🐛 bug fix solution: proposed fix a fix for the issue has been proposed and waits for confirmation

Comments

@ingomueller-net
Copy link

The solutions described in #296 doe not seem to work anymore in 3.9.1. When compiling with -fno-exceptions (with or without JSON_NOEXCEPTIONS set), I get the following error (using Clang 12.0):

/data/3rdparty/json/single_include/nlohmann/json.hpp:16457:9: error: cannot use 'throw' with exceptions disabled
        throw std::out_of_range("key not found");
        ^
/data/3rdparty/json/single_include/nlohmann/json.hpp:16470:9: error: cannot use 'throw' with exceptions disabled
        throw std::out_of_range("key not found");
        ^
2 errors generated.

Using v3.8.0 works as expected (I have only tried without JSON_NOEXCEPTIONS).

@nlohmann
Copy link
Owner

That issue was fixed in #2347.

@ingomueller-net
Copy link
Author

Looks like it. I guess 3.9.2 will have this fixed, then. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug release item: 🐛 bug fix solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Development

No branches or pull requests

2 participants