Use the provided allocator in destroy() (#4842)

veselink1 · veselink1 · commit ff3eaf896364 · 2025-07-04T12:51:14.000+01:00
Uses the provided allocator to allocate the stack used to avoid
recursion in the destroy() implementation used by ~basic_json.
diff --git a/include/nlohmann/json.hpp b/include/nlohmann/json.hpp
@@ -570,7 +570,7 @@ class basic_json // NOLINT(cppcoreguidelines-special-member-functions,hicpp-spec
             if (t == value_t::array || t == value_t::object)
             {
                 // flatten the current json_value to a heap-allocated stack
-                std::vector<basic_json> stack;
+                std::vector<basic_json, allocator_type> stack;
 
                 // move the top-level items to stack
                 if (t == value_t::array)
diff --git a/single_include/nlohmann/json.hpp b/single_include/nlohmann/json.hpp
@@ -20673,7 +20673,7 @@ class basic_json // NOLINT(cppcoreguidelines-special-member-functions,hicpp-spec
             if (t == value_t::array || t == value_t::object)
             {
                 // flatten the current json_value to a heap-allocated stack
-                std::vector<basic_json> stack;
+                std::vector<basic_json, allocator_type> stack;
 
                 // move the top-level items to stack
                 if (t == value_t::array)

Original file line number	Diff line number	Diff line change
`@@ -570,7 +570,7 @@ class basic_json // NOLINT(cppcoreguidelines-special-member-functions,hicpp-spec`
`570`	`570`	`if (t == value_t::array \|\| t == value_t::object)`
`571`	`571`	`{`
`572`	`572`	`// flatten the current json_value to a heap-allocated stack`
`573`		`- std::vector<basic_json> stack;`
	`573`	`+ std::vector<basic_json, allocator_type> stack;`
`574`	`574`
`575`	`575`	`// move the top-level items to stack`
`576`	`576`	`if (t == value_t::array)`
Original file line number	Diff line number	Diff line change
`@@ -20673,7 +20673,7 @@ class basic_json // NOLINT(cppcoreguidelines-special-member-functions,hicpp-spec`
`20673`	`20673`	`if (t == value_t::array \|\| t == value_t::object)`
`20674`	`20674`	`{`
`20675`	`20675`	`// flatten the current json_value to a heap-allocated stack`
`20676`		`- std::vector<basic_json> stack;`
	`20676`	`+ std::vector<basic_json, allocator_type> stack;`
`20677`	`20677`
`20678`	`20678`	`// move the top-level items to stack`
`20679`	`20679`	`if (t == value_t::array)`