LogManager.Shutdown - Should disable file watcher and avoid auto reload

[snakefoot]

One might consider to call LogFactory.Close(), but that might be a breaking change as it would prevent the engine to startup again after shutdown (Would have to fix unit tests, so they don't call LogManager.Shutdown)

Adventure that continues from #1899 and #82

LogManager.Shutdown() was created to simulate Shutdown in Log4net.

[codecov]

Codecov Report

Merging #2616 into master will decrease coverage by <1%.
The diff coverage is 80%.

@@           Coverage Diff           @@
##           master   #2616    +/-   ##
=======================================
- Coverage      81%     81%   -<1%     
=======================================
  Files         326     326            
  Lines       24028   24034     +6     
  Branches     3037    3037            
=======================================
  Hits        19462   19462            
- Misses       3746    3754     +8     
+ Partials      820     818     -2

[snakefoot]

@304NotModified Improved NLogManager.Shutdown() so it performs a more correct shutdown (and also disconnects active loggers from using the closed targets)

Have also disabled the concurrent shutdown-auto-flush on the Linux-platform, as it seems to cause problems for NetCore-Applications (Just like for Mono)

[snakefoot]

@304NotModified Little annoying that creating a new Logger-object actually causes the LoggingConfiguration to be reloaded after having called LogManager.Shutdown().

Have now changed the logic of LogManager.Shutdown(), so it requires an explicit assignment of LogManager.Configuration to startup again.

[snakefoot]

Victims of shutdown-auto-flush not working on Linux (Needs explicit call to NLog.LogManager.Shutdown())

https://github.com/dotnet/corefx/issues/27952
NLog/NLog.Extensions.Logging#201

Better to have unflushed logevents than segmentation fault at application exit (even if no logevents to flush)

[snakefoot]

@304NotModified Would like to have this included in NLog 4.5 RTM if possible.

There are two important changes:

• LogManager.Shutdown() works correctly when autoload=true
• Avoid unhandled exceptions (segmentation fault) when running on Linux, when forgetting to call LogManager.Shutdown.

[304NotModified]

Was doubting about that, but it's merged now :)

[snakefoot]

Thank you for the merge. Any update on the timeline for NLog 4.5 RTM ?

[304NotModified]

Yes, in the weekend 24+25 I have some more free time and i planned the rtm release for then.

[snakefoot]

Very exciting. I will be going on easter holiday from monday the 26th.