Network/NLogViewer/Chainsaw Target - Enabled OptimizeBufferReuse by default, but not for sub classes #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
NetworkTargetOptimizeBufferReuse
branch
from
20425d2 to
0371bb4
Compare
Codecov Report
@@ Coverage Diff @@
## master #2560 +/- ##
=======================================
- Coverage 82% 81% -<1%
=======================================
Files 323 323
Lines 23430 23456 +26
Branches 2936 2940 +4
=======================================
- Hits 19097 19087 -10
- Misses 3554 3575 +21
- Partials 779 794 +15 |
src/NLog/Targets/ChainsawTarget.cs
Outdated
| @@ -67,6 +67,7 @@ public class ChainsawTarget : NLogViewerTarget | |||
| public ChainsawTarget() | |||
| { | |||
| IncludeNLogData = false; | |||
| OptimizeBufferReuse = GetType() == typeof(ChainsawTarget); | |||
There was a problem hiding this comment.
Why not just true? Because of custom sub classes?
There was a problem hiding this comment.
Yes minimum amount of surprises possible.
There was a problem hiding this comment.
Please add this as code comments, thanks in advance!
304NotModified
changed the title
snakefoot
changed the title
snakefoot
force-pushed
the
NetworkTargetOptimizeBufferReuse
branch
13 times, most recently
from
6e5f54a to
1fcefdf
Compare
snakefoot
force-pushed
the
NetworkTargetOptimizeBufferReuse
branch
from
1fcefdf to
36b11c8
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.