Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authentication.md doesn't mention comin user #38

Open
jpds opened this issue May 3, 2024 · 4 comments · May be fixed by #42
Open

authentication.md doesn't mention comin user #38

jpds opened this issue May 3, 2024 · 4 comments · May be fixed by #42

Comments

@jpds
Copy link
Contributor

jpds commented May 3, 2024

The authentication.md document doesn't mention the requirement of the hardcoded comin user:

comin/internal/repository/git.go

Line 25 in 425c747

Username: "comin",

I'd simply created the access token under my own user and gave it to comin - I think this should be configurable.
@nlewo
Copy link
Owner

nlewo commented May 3, 2024

The username is actually not used by the GitLab/GitHub HTTP authentication, but it should not be an empty string. This is why the user comin is hardcoded.

I don't think there is currently a need to make it configurable.

@nlewo nlewo closed this as completed May 3, 2024
@jpds
Copy link
Contributor Author

jpds commented May 3, 2024

This doesn't work on my Forgejo instance because it tries to login as comin - but the token is tied to my account.

@nlewo nlewo reopened this May 4, 2024
@nlewo
Copy link
Owner

nlewo commented May 5, 2024

@jpds Is this documented somewhere in the codeberg documentation?

nlewo added a commit that referenced this issue May 5, 2024
@nlewo
Expose Auth.Username for other forges
5efc0fd 
Fixes #38
@nlewo nlewo linked a pull request May 5, 2024 that will close this issue
Draft
@jpds
Copy link
Contributor Author

jpds commented May 5, 2024

Basically, all I see is:

routers/web/web.go:120:func7() [E] Failed to verify user: user does not exist [uid: 0, name: comin]

I did also try renaming my normal user to comin and started getting:

...rvices/auth/basic.go:130:Verify() [E] UserSignIn: user's password is invalid [uid: 1, name: comin]
routers/web/web.go:120:func7() [E] Failed to verify user: user's password is invalid [uid: 1, name: comin]

@itz-Jana itz-Jana mentioned this issue Nov 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose Auth.Username for other forges nlewo/comin
2 participants
@nlewo @jpds