Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Nix Darwin support #12

Open
Pablo1107 opened this issue Mar 8, 2024 · 3 comments
Open

[Feature Request] Nix Darwin support #12

Pablo1107 opened this issue Mar 8, 2024 · 3 comments

Comments

@Pablo1107
Copy link

It would be nice if this could also export a Nix Darwin module to pull the config and switch to it.

@zowoq
Copy link
Contributor

zowoq commented Apr 22, 2024

nix-darwin doesn't seem to have an equivalent to restartIfChanged so services are always restarted which then conflicts with comin attempting to switch to a new generation.

AFAIK cachix deploy is the only other pull type deployment tool with nix-darwin support, it seems to create a new process group for the deployment instead of doing anything like restartIfChanged = false.

@zowoq
Copy link
Contributor

zowoq commented May 1, 2024

@nlewo Any thoughts on a way forward for this?

I could look at adding a restartIfChanged equivalent to nix-darwin but I can't find any requests in nix-darwin for the feature and the relevant bit of code hasn't been touched for six years so I wouldn't be surprised if the nix-darwin maintainers are reluctant to accept it.

@nlewo
Copy link
Owner

nlewo commented May 1, 2024

I actually don't have any experience with nix-darwin and i don't have nix-darwin runners. So, i'm a bit afraid by adding the support of nix-darwin, if I'm not able to maintain it. I would then prefer to minimize the comin codebase differences between linux and darwin.

I could look at adding a restartIfChanged equivalent to nix-darwin

It would be really nice to add this option in nix-darwin. Maybe you could first create an issue to see what they think about this.

I could then make comin more configuration to support more switch commands (this could also be useful to support home manager).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants