Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong path generated #15

Open
pi31416chan opened this issue Apr 7, 2024 · 0 comments · May be fixed by #16
Open

Wrong path generated #15

pi31416chan opened this issue Apr 7, 2024 · 0 comments · May be fixed by #16

Comments

@pi31416chan
Copy link

There is a missing backslash in both the path to icon and path to the cmd file to launch the shell.
It should be (example) C:\\msys64\msys2.ico, but generated C:\\msys64msys2.ico
It should be (example) C:\\msys64\msys2_shell.cmd, but generated C:\\msys64msys2_shell.cmd
Artoria2e5 added a commit to Artoria2e5/msys2-mingw-shortcut-menus that referenced this issue Aug 15, 2024
@Artoria2e5
install: add backslash if not present
c51ccaa 
This fixes njzhangyifei#15. Yes, I've tried it.
@Artoria2e5 Artoria2e5 linked a pull request Aug 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

install: add backslash if not present Artoria2e5/msys2-mingw-shortcut-menus
1 participant
@pi31416chan