Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is pry-nav discouraged for MRI? #41

Open
justin808 opened this issue Dec 16, 2021 · 3 comments
Open

Why is pry-nav discouraged for MRI? #41

justin808 opened this issue Dec 16, 2021 · 3 comments

Comments

@justin808
Copy link
Contributor

justin808 commented Dec 16, 2021 •
edited
Loading

Why is pry-nav discouraged for MRI?

Per the README:

Using MRI? We recommend break or pry-byebug instead!

pry-byebug has some issue with zeitwerk
@iloveitaly
Copy link
Collaborator

@justin808 honestly, not sure. Want to submit a PR to change this?

Most likely, https://github.com/ruby/debug is going to be the path forward, but can't hurt to update this for now.

@nixme
Copy link
Owner

nixme commented Dec 17, 2021

Agreed with @iloveitaly that ruby/debug will be the path forward, but I originally put the recommendation because pry-nav uses set_trace_func which at the time was much slower than byebug. Ruby docs also say set_trace_func is obsolete. We could change to the TracePoint API and remove that recommendation.

@justin808
Copy link
Contributor Author

@iloveitaly Here you go: #42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nixme @iloveitaly @justin808