Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discarding strategy #17

Closed
deemp opened this issue Feb 25, 2023 · 0 comments · Fixed by #21
Closed

Improve discarding strategy #17

deemp opened this issue Feb 25, 2023 · 0 comments · Fixed by #21

Comments

@deemp
Copy link
Collaborator

deemp commented Feb 25, 2023

We discard the extensions based on a single request. It may be better to discard them when they're unavailable multiple times.

What we do now:

  1. Each run, we get a list of extensions from API.
  2. We look at the extensions that aren't present in our json and fetch them.
  3. We discard from that json the extensions that aren't present in the API response.
  4. We add the new extensions into json.

How we can improve discarding:

    • Add a field unavailable_count to an extension info. It will record how many times the extension was unavailable.
    • If an extension reaches some threshold, it is discarded.
    • When it's present in a next API response, its counter will be set to 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant