Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: HM always writes settings.json for zed #6193

Closed
2 tasks done
DaRacci opened this issue Dec 11, 2024 · 2 comments
Closed
2 tasks done

bug: HM always writes settings.json for zed #6193

DaRacci opened this issue Dec 11, 2024 · 2 comments
Assignees
Labels
bug triage Issues or feature request that have not been triaged yet

Comments

@DaRacci
Copy link
Contributor

DaRacci commented Dec 11, 2024

Are you following the right branch?

  • My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

  • I have searched the existing issues

Issue description

When using zed-editor, I've configured no settings or extensions but there is still a settings.json file generated.

I've figured out the issue comes from this

# this part by @cmacrae
auto_install_extensions = lib.genAttrs cfg.extensions (_: true);

Later on when the config is checked for being empty it will never be empty because auto_install_extensions will always be in mergedSettings even if there were none defined.

Maintainer CC

No response

System information

- system: `"x86_64-linux"`
 - host os: `Linux 6.11.11-xanmod1, NixOS, 25.05 (Warbler), 25.05.20241209.a73246e`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Lix, like Nix) 2.92.0-dev-pre20241210-8ddcdfb
System type: x86_64-linux
Additional system types: i686-linux, x86_64-v1-linux, x86_64-v2-linux, x86_64-v3-linux
Features: gc, signed-caches
System configuration file: /etc/nix/nix.conf
User configuration files: /home/racci/.config/nix/nix.conf:/nix/store/dfn5fg6l506vm7n8cchfys27x4wj27iy-stylix-kde-config/nix/store/dfn5fg6l506vm7n8cchfys27x4wj27iy-stylix-kde-config/etc/xdg/nix/nix.conf:/home/racci/.nix-profile/etc/xdg/nix/nix.conf:/nix/profile/etc/xdg/nix/nix.conf:/home/racci/.local/state/nix/profile/etc/xdg/nix/nix.conf:/etc/profiles/per-user/racci/etc/xdg/nix/nix.conf:/nix/var/nix/profiles/default/etc/xdg/nix/nix.conf:/run/current-system/sw/etc/xdg/nix/nix.conf
Store directory: /nix/store
State directory: /nix/var/nix
Data directory: /nix/store/wpr7kirrxzz1l8kb17vwnqggl8dbcly4-lix-2.92.0-dev-pre20241210-8ddcdfb/share`
 - nixpkgs: `/nix/store/yw6kg4rb9v8s3ypjbpspig5r81m4lr5s-source`
@DaRacci DaRacci added bug triage Issues or feature request that have not been triaged yet labels Dec 11, 2024
@teto
Copy link
Collaborator

teto commented Dec 11, 2024

classic problem. PR welcome

@DaRacci
Copy link
Contributor Author

DaRacci commented Dec 14, 2024

Fixed in 66c5d8b

@DaRacci DaRacci closed this as completed Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Issues or feature request that have not been triaged yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants