buildGoApplication.override fails

[eliasnaur]

See https://discourse.nixos.org/t/overriding-stdenv-of-gomod2nix-buildgoapplication/26364 where I try to override stdenv of buildGoApplication. I believe override worked at some point, as evidenced by https://github.com/doronbehar/pistol/blob/d4a4290269357d3f98b03a4e8f730a2063ce22bb/flake.nix#L45

Error message:

% nix build github:eliasnaur/gomod2nix-stdenv
error:
       … while evaluating the attribute 'buildGoApplication.override'

         at /nix/store/y6p51jza33989fck64faj0wyk2b1cp15-source/overlay.nix:8:38:

            7| {
            8|   inherit (callPackage ./builder { }) buildGoApplication mkGoEnv;
             |                                      ^
            9|   gomod2nix = callPackage ./default.nix { };

       … while selecting an attribute

         at /nix/store/gg4swr5bg6md0rygxf8q7kbr0w053mh6-source/flake.nix:20:29:

           19|       in {
           20|         packages.default = (pkgs.buildGoApplication.override { stdenv = pkgs.llvmPackages_14.stdenv; }) {
             |                             ^
           21|           name = "test";

       error: value is a function while a set was expected

Source

https://github.com/eliasnaur/gomod2nix-stdenv/blob/8e6f64962cc51ff712980ed92904b193ad19f7f0/flake.nix#L20

[eliasnaur]

git bisect points at https://github.com/nix-community/gomod2nix/commits/a4bed25a864cd226569f655f8b1c17c0ccb28079 as the commit that broke override.

[eliasnaur]

I can confirm the following hack restores override functionality:

diff --git a/builder/default.nix b/builder/default.nix
index d500555..ecd4946 100644
--- a/builder/default.nix
+++ b/builder/default.nix
@@ -436,6 +436,4 @@ let
       });

 in
-{
-  inherit buildGoApplication mkGoEnv;
-}
+ buildGoApplication
diff --git a/overlay.nix b/overlay.nix
index 9010386..64d86cb 100644
--- a/overlay.nix
+++ b/overlay.nix
@@ -5,6 +5,6 @@ let
   callPackage = final.darwin.apple_sdk_11_0.callPackage or final.callPackage;
 in
 {
-  inherit (callPackage ./builder { }) buildGoApplication mkGoEnv;
+  buildGoApplication = (callPackage ./builder { });
   gomod2nix = callPackage ./default.nix { };
 }