Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay #102

Open
jbboehr opened this issue Feb 3, 2023 · 0 comments
Open

Overlay #102

jbboehr opened this issue Feb 3, 2023 · 0 comments

Comments

@jbboehr
Copy link

jbboehr commented Feb 3, 2023

I was experimenting with packaging a Go program recently I noticed gomod2nix was using an overlay for it's own copy of nixpkgs, which, after a cursory browse of the source, seems unnecessary. Have you thought about removing it?

See: nix-community/poetry2nix@05b788f / https://zimbatm.com/notes/1000-instances-of-nixpkgs

[overlays] have a real performance impact as each flake would introduce its own instance of nixpkgs, which can further multiply if these flakes are than import into multiple NixOS configurations

As an idea, perhaps expose buildGoApplication and mkGoEnv on a lib attribute like: https://github.com/cachix/pre-commit-hooks.nix/blob/5668d079583a5b594cb4e0cc0e6d84f1b93da7ae/flake.nix#L51

Hope I didn't come off as too critical - just an idea for the idea bin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant