Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping --leave-dotGit breaks nix-bundle-install #60

Open
peterhoeg opened this issue Jul 5, 2019 · 2 comments
Open

Dropping --leave-dotGit breaks nix-bundle-install #60

peterhoeg opened this issue Jul 5, 2019 · 2 comments

Comments

@peterhoeg
Copy link

#51 has broken things when pointing at git repository in the Gemfile.

# Gemfile
gem 'sensu-plugins-ipmi', git: 'https://github.com/sensu-plugins/sensu-plugins-ipmi', branch: 'master'

The problem is that nix-bundle-install expects the .git directory to exist when building from a git checkout and therefore fails when it is missing.

The problem is that since we are specifying a revision (either a branch, tag or actual commit id), nix-bundle-install needs a proper repo in order to do a proper checkout of the correct revision.

Reverting #51, deleting gemset.nix for the gem in question and running bundix makes everything work again.

@bflyblue
Copy link

bflyblue commented Apr 6, 2020

I'm having the same issue, any chance of getting this looked at? If someone can explain the right solution I can try do the actual work. Do we need to revert #51 or update nix-bundle-install to not expect the .git directory?

@peterhoeg
Copy link
Author

peterhoeg commented Apr 7, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants