Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6] Runtime and Data Driven Styling Support #643

Merged
merged 29 commits into from
Sep 26, 2017
Merged

Conversation

nitaliano
Copy link
Owner

@nitaliano nitaliano commented Sep 22, 2017

Adds support for some layers and sources

Layers

  • FillLayer
  • FillExtrusionLayer
  • CircleLayer
  • SymbolLayer
  • LineLayer
  • RasterLayer
  • BackgroundLayer

Sources

  • VectorSource
  • ShapeSource
  • RasterSource

Other Components

  • MapboxGL.StyleSheet
  • Light

Here are some screens

Marker Clustering
marketclustering

Fill Extrusion
buildings

Runtime styling in action
ocean

cc @boundsj @zugaldia @bsudekum

@1ec5
Copy link
Contributor

1ec5 commented Sep 23, 2017

You might find this JSON file and this reference document handy as you build out the MGLStyleLayer support for iOS, since many property names and types diverged from the style specification in order to match Objective-C and Swift conventions.

@nitaliano
Copy link
Owner Author

@1ec5 I'm using the map from that file here and from there I'm autogenerating all of the style code similar to gl-native

Autogeneration script

Templates directory

The style code that gets output for iOS is here
RCTMGLStyle.h
RCTMGLStyle.m

@nitaliano nitaliano changed the title Feature/v6 runtime styling [v6] Runtime and Data Driven Styling Support Sep 23, 2017
@henrikra
Copy link
Contributor

Holy fuck 🥇

@nitaliano
Copy link
Owner Author

I plan on merging this into v6 at some point today.

@nitaliano nitaliano merged commit c540116 into v6 Sep 26, 2017
@nitaliano nitaliano deleted the feature/v6-runtime-styling branch September 26, 2017 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants