[FIX] Set length to 1 when np.squeeze returns a 0D array #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Feb 11, 2025
|
@man-shu I'm not sure if this code actually gets tested by our tests. If you're testing on your end, please make sure that it works in cases where it was previously failing. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3713 +/- ##
==========================================
- Coverage 73.06% 73.05% -0.02%
==========================================
Files 1278 1278
Lines 59356 59355 -1
==========================================
- Hits 43367 43359 -8
- Misses 15989 15996 +7 ☔ View full report in Codecov by Sentry. |
Ok will update you on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3712 .
List of changes proposed in this PR (pull-request)
idxsidxsis a 0D array)nelsto 1