Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): Move to tox to simplify test/CI setup #3326

Merged
merged 9 commits into from
Jul 17, 2024

Conversation

effigies
Copy link
Member

Had this in a branch for a bit. I think it's working...

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.03%. Comparing base (70209ee) to head (d4eeb42).
Report is 94 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3326      +/-   ##
==========================================
- Coverage   73.68%   71.03%   -2.65%     
==========================================
  Files          56       56              
  Lines        4233     4233              
  Branches        0      638     +638     
==========================================
- Hits         3119     3007     -112     
  Misses       1114     1114              
- Partials        0      112     +112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member Author

All coverage losses are a result of using branch tracing so that ifs are only considered fully covered if both the True and False paths are hit.

image

@effigies
Copy link
Member Author

Any objections? Otherwise will merge today.

@effigies effigies merged commit b5a3674 into nipreps:master Jul 17, 2024
17 of 18 checks passed
@effigies effigies deleted the tox branch July 17, 2024 17:36
effigies added a commit that referenced this pull request Sep 16, 2024
24.1.0 (September 16, 2024)

New feature release in the 24.1.x series.

Handling of gradient echo fieldmaps is improved.

  * FIX: Select volumetric dseg.tsv from recent TemplateFlow releases (#3257)
  * RF: Adapt to less T1w-centric smriprep (#3333)
  * RF: Use acres over vendored data loader (#3323)
  * DOC: Add benchmark page (#3312)
  * MAINT: Move to tox to simplify test/CI setup (#3326)
  * CI: Fix expected outputs for fieldmaps (#3321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant