test refactor that uses LayeredIdTable in sigmatch #24198
Draft
+257
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metagn
force-pushed
the
sigmatch-layered-type-map
branch
from
80fa67e
to
467e6f5
Compare
|
Seems like it will work with some touch ups, opening separate PR for LayeredIdTable first to not complicate review. Edit: #24216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is required for a good solution of #4858 but I'm not sure how it'll turn out, testing this by itself first.
There might be a performance hit because of the double pointer indirection. Edit: There is a little bit, I tried changing to object but
setToPreviousLayersegfaulted in nimsuggest which uses--gc:markAndSweep, I can't find a workaround.