Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deeply nested messages may conflict #155

Open
zack-littke-smith-ai opened this issue Jan 10, 2024 · 2 comments
Open

Deeply nested messages may conflict #155

zack-littke-smith-ai opened this issue Jan 10, 2024 · 2 comments

Comments

@zack-littke-smith-ai
Copy link

zack-littke-smith-ai commented Jan 10, 2024

Hello! I've noticed an issue where a nested message may conflict with another. For example (forgive the terrible names and missing boilerplate):

message OutermostA {
  message Inner {
    enum Innermost {
      reserved 1;
    }
  }
}

message OutermostB {
  message Inner {
    enum Innermost {
      reserved 1;
    }
  }
}

We see a lock file where the names of both OutermostA.Inner.Innermost and OutermostB.Inner.Innermost are only Inner.Innermost and may conflict (like above)

@nilslice
Copy link
Owner

Hi @zack-littke-smith - is this level of nesting (enum nested 2 levels within a parent message) the first at which you notice the issue? Or does something like this also produce the same issue:

message Inner {
  enum Innermost {
     reserved 1;
  }
}

@zack-littke-smith-ai
Copy link
Author

zack-littke-smith-ai commented Apr 1, 2024

I believe this only occurs in the nested case, would not be an issue in the example you provide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants