Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website incorrectly reports backwards compatibility with invalid proto files #123

Open
DarrienG opened this issue Oct 16, 2019 · 2 comments

Comments

@DarrienG
Copy link

DarrienG commented Oct 16, 2019

My guess is this is the proper place to post issues for the website protolock.dev If it isn't, feel free to point me somewhere else.

Go to protolock.dev, hit the init button. Make an incompatible change to the proto file (e.g. change SERVICE_UNKNOWN = 3 -> SERVICE_UNKNOWN = 9) and then make the proto file invalid, e.g. s/rpc/dog/g and it will mark it as backwards compatible.

This actually isn't the case with the CLI:

$ protolock status         
[protolock]: root.proto:17:5: found "dog" but expected [service comment|rpc]

So I figure this is a bug.

@nilslice
Copy link
Owner

@DarrienG -- thanks for reporting! I'll try to reproduce and then update the WASM binary to a version built with the latest protolock code.

Can you tell me a bit more about your environment? Which browser and OS (and their versions) are you using?

@DarrienG
Copy link
Author

Glad I can help! I love the product.

It happens on Firefox v69/70 on macOS Catalina.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants