Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOSSA picking up GPL in scan #64

Closed
jhbeskow opened this issue Jun 19, 2024 · 4 comments
Closed

FOSSA picking up GPL in scan #64

jhbeskow opened this issue Jun 19, 2024 · 4 comments

Comments

@jhbeskow
Copy link
Contributor

I have looked through your closed issues and see that the dual license has been removed in favor of MIT. However, the license is very unclear here. We are seeing a FOSSA flag for GPL. A GPL license is being picked up in LICENSE.MD while MIT is listed as the only license in the package.json. Either the GPL license text needs to be removed from the license file or the package.json needs to list both for clarity. When dealing with closed-source products, you cannot take the risk with these licenses.

@niksy
Copy link
Owner

niksy commented Jun 20, 2024

Thanks for noticing this! I guess it should be defined as per package.json description.

PR welcome!

@jhbeskow
Copy link
Contributor Author

jhbeskow commented Jun 21, 2024

Before I can, I need to understand a few things. Why does the LICENSE file have the GPL license in it if it's not dual licensed? It seems like the GPL license needs to be removed from there if this is not required. i.e. Are any of your dependencies GPL? EDIT: I think your dependencies are GPL clean.

Also, what is the Copyright (c) 2010 "Cowboy" Ben Alman license? Does that need to stay?

@niksy
Copy link
Owner

niksy commented Jun 22, 2024

This package originally comes from jQuery plugin by Ben Alman. Source code was heavily modified to remove jQuery as dependancy, but I wanted to keep attribution to original package.

I think this can be removed now and only MIT license can stay.

@niksy
Copy link
Owner

niksy commented Jun 24, 2024

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants