Skip to content

Commit 8c6a0c0

Browse files
committed
fix tests, remove binary naming template - reverting to default behavior (based on dir of project)
1 parent 890aa53 commit 8c6a0c0

File tree

5 files changed

+17
-15
lines changed

5 files changed

+17
-15
lines changed

metadata.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "2.12.1",
2+
"version": "2.13.0",
33
"package": "github.com/nikogura/gomason",
44
"description": "A tool for testing, building, signing, and publishing your project from a clean workspace.",
55
"repository": "http://localhost:8081/artifactory/generic-local",

pkg/gomason/golang.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -312,9 +312,11 @@ func (g Golang) Build(gopath string, meta Metadata, skipTargets string, local bo
312312
logrus.Debugf("LD Flag: %s", ldflags)
313313
}
314314

315-
outputTemplate := fmt.Sprintf("%s_{{.OS}}_{{.Arch}}", meta.Name)
315+
// Interesting idea, but breaks multiple binary builds such as dbt. To properly implement, we'd have to find and handle each binary instead of relying on the './...'.
316+
//outputTemplate := fmt.Sprintf("%s_{{.OS}}_{{.Arch}}", meta.Name)
317+
//args := gox + cgo + ldflags + ` -osarch="` + target.Name + `"` + ` -output="` + outputTemplate + `"` + " ./..."
316318

317-
args := gox + cgo + ldflags + ` -osarch="` + target.Name + `"` + ` -output="` + outputTemplate + `"` + " ./..."
319+
args := gox + cgo + ldflags + ` -osarch="` + target.Name + `"` + " ./..."
318320

319321
logrus.Debugf("Running gox with: %s in dir %s", args, wd)
320322

pkg/gomason/golang_test.go

+8-8
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ func TestPrep(t *testing.T) {
9191
t.Errorf("Failed to checkout module")
9292
}
9393

94-
err = lang.Prep(gopath, testMetadataObj())
94+
err = lang.Prep(gopath, testMetadataObj(), false)
9595
if err != nil {
9696
t.Errorf("error running prep steps: %s", err)
9797
}
@@ -167,12 +167,12 @@ func TestBuild(t *testing.T) {
167167
t.Errorf("Failed to checkout module")
168168
}
169169

170-
err = lang.Prep(gopath, testMetadataObj())
170+
err = lang.Prep(gopath, testMetadataObj(), false)
171171
if err != nil {
172172
t.Errorf("error running prep steps: %s", err)
173173
}
174174

175-
err = lang.Build(gopath, testMetadataObj(), tc.skipTargets)
175+
err = lang.Build(gopath, testMetadataObj(), tc.skipTargets, false)
176176
if err != nil {
177177
t.Errorf("Error building: %s", err)
178178
}
@@ -218,12 +218,12 @@ func TestTest(t *testing.T) {
218218
t.Errorf("Failed to checkout module")
219219
}
220220

221-
err = lang.Prep(gopath, testMetadataObj())
221+
err = lang.Prep(gopath, testMetadataObj(), false)
222222
if err != nil {
223223
t.Errorf("error running prep steps: %s", err)
224224
}
225225

226-
err = lang.Test(gopath, testMetadataObj().Package, "10m")
226+
err = lang.Test(gopath, testMetadataObj().Package, "10m", false)
227227
if err != nil {
228228
t.Errorf("error running go test: %s", err)
229229
}
@@ -259,7 +259,7 @@ func TestSignVerifyBinary(t *testing.T) {
259259
meta.Repository = fmt.Sprintf("http://localhost:%d/repo/tool", servicePort)
260260

261261
// build artifacts
262-
err = lang.Build(gopath, meta, "")
262+
err = lang.Build(gopath, meta, "", false)
263263
if err != nil {
264264
t.Errorf("Error building: %s", err)
265265
}
@@ -338,12 +338,12 @@ Expire-Date: 0
338338
t.Errorf("Failed to get current working directory: %s", err)
339339
}
340340

341-
err = g.HandleArtifacts(meta, gopath, cwd, false, true, true, "")
341+
err = g.HandleArtifacts(meta, gopath, cwd, false, true, true, "", false)
342342
if err != nil {
343343
t.Errorf("post-build processing failed: %s", err)
344344
}
345345

346-
err = g.HandleExtras(meta, gopath, cwd, false, true, true)
346+
err = g.HandleExtras(meta, gopath, cwd, false, true, true, false)
347347
if err != nil {
348348
t.Errorf("Extra artifact processing failed: %s", err)
349349
}

pkg/gomason/gomason.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ func init() {
1919
}
2020

2121
// VERSION is the current gomason version
22-
const VERSION = "2.12.1"
22+
const VERSION = "2.13.0"
2323

2424
// METADATA_FILENAME The default gomason metadata file name
2525
const METADATA_FILENAME = "metadata.json"

pkg/gomason/languages_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ func TestNoLanguage(t *testing.T) {
1515
err = nl.Checkout("", Metadata{}, "")
1616
assert.True(t, err == nil, "Checkout returned an error")
1717

18-
err = nl.Prep("", Metadata{})
18+
err = nl.Prep("", Metadata{}, false)
1919
assert.True(t, err == nil, "Prep returned an error")
2020

21-
err = nl.Test("", "", "")
21+
err = nl.Test("", "", "", false)
2222
assert.True(t, err == nil, "Test returned an error")
2323

24-
err = nl.Build("", Metadata{}, "")
24+
err = nl.Build("", Metadata{}, "", false)
2525
assert.True(t, err == nil, "Build returned an error")
2626

2727
}

0 commit comments

Comments
 (0)