Unescape vars

[ondrejmirtes]

I have a dispatcher like this:

\FastRoute\simpleDispatcher(function (\FastRoute\RouteCollector $r): void {
	$r->addRoute('GET', '/license/{package}', $this->licenseHandler);
});

When I visit a URL that looks like this:

/license/clue%2Fndjson-react

I'd expect to receive clue/ndjson-react in $vars['package'] here:

$routeInfo = $this->getDispatcher()->dispatch($request->getMethod(), $request->getUri()->getPath());
$vars = $routeInfo[2];

But instead I receive /license/clue%2Fndjson-react, leaving the unescaping to the handler.

[nikic]

The expectation is that dispatch() receives an already decoded URI. The example in https://github.com/nikic/FastRoute#usage uses rawurldecode() to that effect.

[ondrejmirtes]

The problem with that is that it's not lossless.

Consider this route:

/{foo}/{bar}. Having /one%2Ftwo/three%2Ffour would yield foo being one/two and bar being three/four. But after rawurldecode, it becomes /one/two/three/four, being unable to extract the parameters in a deterministic way.

I know this is an edge case but they usually show wrong abstractions :) Feel free to close this as this is easily solvable in the handler, I'm just used to different behaviour from MVC frameworks...