Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrade, assert.urlEquals fails even though same URL is given #1179

Closed
ianwalter opened this issue Sep 14, 2016 · 4 comments
Closed

After upgrade, assert.urlEquals fails even though same URL is given #1179

ianwalter opened this issue Sep 14, 2016 · 4 comments

Comments

@ianwalter
Copy link

After upgrading from v0.8.18 to v0.9.8, I get this error on every test that uses urlEquals:

   Testing if the URL equals "function url() {
       return this.api.globals.targetHost + '/sign-in';
     }".  - expected "http://localhost:8888/sign-in" but got: "http://localhost:8888/sign-in"

Has the way to specify the URL in a page-object changed?

Node v5.11.0
NPM 3.8.6
Running from OS X latest, testing locally and on BrowserStack Windows 8.1, Chrome 52

@senocular
Copy link
Contributor

This is most likely from the url change in v0.9.6. Now the url method is resolved at time of evaluation rather than when the page is created allowing users to change the url at runtime (supporting both string and function variations): #1034.

Can you provide a sample test example where this fails as you describe?

@ianwalter
Copy link
Author

Yes, will provide a test example. It does start failing in 0.9.6.

@ianwalter
Copy link
Author

@senocular Well I'm 121 days late, but here is a reproduction of the issue:
https://github.com/optick/vueform/blob/master/test/e2e/specs/home.js

@ianwalter
Copy link
Author

Closing, I must not have read your comment closely enough the first time. With the change you mentioned, I simply have to call the url method instead of treating it as a property. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants