Nightwatch hangs when Selenium fails to create a session

[MadaraUchiha]

Because the module in HttpRequest.js doesn't have an option of a timeout, when Selenium fails to respond with a session, Nightwatch will wait for it indefinitely (until Selenium itself is timed out, which by default is 10 minutes).

This causes the runner to be idle for 10 minutes, and then fail the test.

I propose adding a new timeout configuration option to the HttpRequest module. I'm willing to put a PR in, I want to ask if there are existing conventions for passing config, and whether there are tests covering that part of the library.

[beatfactor]

Yes, there are in test/src/http/testRequest.js and also in test/src/index/testNightwatchIndex.js.

It should probably be something like the default_path_prefix in https://github.com/nightwatchjs/nightwatch/blob/master/lib/index.js#L134. Docs will also need to be updated, at https://github.com/nightwatchjs/nightwatch-docs.

[diegoprd]

I dont know if you have seen it but quite a lot of people is having an issue when running Nightwatch tests in circleCi... Ive been looking into that issue for a while... to get to understand that is exactly this case....

handling request timeout would solve this issue!
+1
👍

[beatfactor]

@diegoprd I don't think the timeout will help your problem with circle-ci. From what I've noticed they are running quite an old version of chrome so you might need to downgrade your chromedriver version. I suggest to post a new message on the mailing list regarding the circleci issue.

[beatfactor]

Fixed as part of #1232.