Fix #470 - disable stdin pipe between selenium java process and night…

…watch to address linux issues
nightwatchjs · Aug 15, 2016 · df10355 · df10355
1 parent e8b8b6a
commit df10355
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/runner/selenium.js b/lib/runner/selenium.js
@@ -50,7 +50,10 @@ SeleniumServer.prototype.start = function() {
   }
 
   this.setCliArgs();
-  this.process = child_process.spawn('java', this.cliOpts);
+  this.process = child_process.spawn('java', this.cliOpts, {
+    stdio: ['ignore', 'pipe', 'pipe']
+  });
+
   this.process.host = this.host;
   this.process.port = this.port;
   this.exitHandlerFn = this.exitHandler.bind(this);

diff --git a/test/src/runner/testSelenium.js b/test/src/runner/testSelenium.js
@@ -38,6 +38,7 @@ module.exports = {
 
     testStartServer : function(done) {
       this.mockedSpawn.setStrategy(function (command, args, opts) {
+        assert.deepEqual(opts, {stdio : ['ignore', 'pipe', 'pipe']});
         if (command !== 'java') {
           return null;
         }
@@ -59,7 +60,6 @@ module.exports = {
           }
         }
       }, function(error, process) {
-        assert.ok('Callback called');
         assert.equal(process.command, 'java');
         assert.deepEqual(process.args, ['-jar', './selenium.jar', '-port', 4444, '-host', '127.0.0.1', '-Dwebdriver.test.property=test', '-DpropName=1']);
         assert.equal(process.host, '127.0.0.1');