Added support to exit using non-zero exit code on mocha failures

Author: beatfactor

examples/mocha/github.js

@@ -5,14 +5,18 @@ describe('Github', function() {
       .url('https://github.com/nightwatchjs/nightwatch')
       .waitForElementVisible('body', 1000)
       .assert.title('nightwatchjs/nightwatch · GitHub')
-      .assert.visible('.container .breadcrumb a span')
-      .assert.containsText('.container .breadcrumb a span', 'nightwatch', 'Checking project title is set to nightwatch');
+      .assert.visible('.container h1 strong a')
+      .assert.containsText('.container h1 strong a', 'nightwatch', 'Checking project title is set to nightwatch');
   });
 
   after(function(client, done) {
-    client.end(function() {
+    if (client.sessionId) {
+      client.end(function() {
+        done();
+      });
+    } else {
       done();
-    });
+    }
   });
 
 });

examples/tests/github.js

@@ -3,10 +3,10 @@ module.exports = {
   'Demo test GitHub' : function (client) {
     client
       .url('https://github.com/nightwatchjs/nightwatch')
-      .waitForElementVisible('body', 1000)
+      .waitForElementVisible('xbody', 1000)
       .assert.title('nightwatchjs/nightwatch · GitHub')
-      .assert.visible('.container .breadcrumb a span')
-      .assert.containsText('.container .breadcrumb a span', 'nightwatch', 'Checking project title is set to nightwatch');
+      .assert.visible('.container h1 strong a')
+      .assert.containsText('.container h1 strong a', 'nightwatch', 'Checking project title is set to nightwatch');
   },
 
   after : function(client) {

lib/runner/cli/clirunner.js

@@ -392,6 +392,10 @@ CliRunner.prototype = {
             fn(null, {
               failed : failures
             });
+
+            if (failures) {
+              process.exit(10);
+            }
           });
 
         }.bind(this));

tests/run_tests.js

@@ -32,12 +32,13 @@ try {
       'src/runner',
       'src/expect',
       'src/page-object',
-      'src/mocha',
       'src/protocol',
       'src/http',
       'src/index',
       'src/assertions',
-      'src/commands'
+      'src/mocha',
+      'src/commands',
+
     ], options, function(err) {
       setTimeout(function() {
         server.close();

tests/src/mocha/testMochaIntegration.js

@@ -1,6 +1,7 @@
 var BASE_PATH = process.env.NIGHTWATCH_COV ? 'lib-cov' : 'lib';
 var CliRunner = require('../../../'+ BASE_PATH +'/runner/cli/clirunner.js');
 
+var originalExit = process.exit;
 module.exports = {
   setUp: function(callback) {
 
@@ -10,6 +11,7 @@ module.exports = {
   tearDown: function(callback) {
     process.removeAllListeners('exit');
     process.removeAllListeners('uncaughtException');
+    process.exit = originalExit;
     callback();
   },
 
@@ -19,15 +21,19 @@ module.exports = {
       env : 'default'
     }).init();
 
+    test.expect(15);
     runner.test_settings.globals = {
       test : test
     };
 
-    test.expect(14);
+    process.exit = function(code) {
+      test.equals(code, 10);
+      test.done();
+    };
+
     runner.runner(function(err, results) {
       test.equals(err, null);
       test.equals(results.failed, 2);
-      test.done();
     });
   }
 };