Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong language codes #2

Closed
burningtree opened this issue Feb 19, 2024 · 2 comments
Closed

Wrong language codes #2

burningtree opened this issue Feb 19, 2024 · 2 comments

Comments

@burningtree
Copy link
Contributor

burningtree commented Feb 19, 2024

The generally accepted standard for designating languages is ISO 639-2, but this repository uses some weird coding.

https://en.wikipedia.org/wiki/List_of_ISO_639-2_codes

For example:

  • czech language: cs (mislabeled as cz)
  • japan language: ja (mislabeled as jp)
  • greek language: el (mislabeled as gr)
  • swedish language: sv (mislabeled as se)

Given the codes, I assume someone is confusing national domain and country codes with language codes - they are not the same. I haven't checked all the codes, most seem correct (like Estonian et, where Estonian country code & domain is ee).

@niclaz
Copy link
Owner

niclaz commented Feb 20, 2024

Thanks for correcting it Tree!

Yeah... I wasn't following ISO when naming the pdfs and some of them were collected already named as they were

Thanks for going through and finding these errors, happy to have them named better

@niclaz
Copy link
Owner

niclaz commented Feb 20, 2024

I made the above edits to the main branch of the archive

Thanks tree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants