Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag format for pre-release versions does not follow semantic versioning standard breaking the "dep" tool #104

Closed
ray-harris opened this issue May 11, 2018 · 2 comments
Milestone

Comments

@ray-harris
Copy link

The dep tool is becoming the standard mechanism for managing dependencies in go. It follows the semantic versioning rules outlined in https://semver.org

Current in the project, there are two pre-release tags, v2.0.0.beta.1 and v2.0.0.beta.2, but they don't follow the semver rules. They should be v2.0.0-beta.1 and v2.0.0-beta.2 instead.

Not following the semver rules causes dep to break when trying to use these versions. The only way to get it to work is to pin the exact branch using the revision constraint instead of the version constraint.

Recommend committing a tag such as v2.0.0-beta.2 to allow dependency management with dep during pre-release.

This is the revision constraint that works but doesn't allow upgrading to a newer version when it's released:

[[constraint]]
  name = "github.com/nicksnyder/go-i18n"
  revision = "v2.0.0.beta.2"

This would be the preferred way of specifying the constraint using version:

[[constraint]]
  name = "github.com/nicksnyder/go-i18n"
  version = "v2.0.0-beta.2"

Thanks

@nicksnyder
Copy link
Owner

Oops! This was not intentional and I will fix.

@nicksnyder
Copy link
Owner

I tagged a new release v2.0.0-beta.3 and added proper tags for the previous releases.

@nicksnyder nicksnyder added this to the v2 milestone May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants