Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for builds based on docker #214

Open
notaphplover opened this issue Mar 23, 2019 · 0 comments
Open

Add docs for builds based on docker #214

notaphplover opened this issue Mar 23, 2019 · 0 comments

Comments

@notaphplover
Copy link

notaphplover commented Mar 23, 2019

Hi, I've been using this library for sending a coverage report from a dockerized build hosted in Travis-CI.

At first I was unable to understand why coveralls.io builds had a coverage report but not a branch name nor a commit msg. At the end I had to read the library's code and this article to understand that node-coveralls needed some magic env variables from Travis in order to know the current branch.

I'm here just to suggest to add a few lines to the README.md file in order to explain that code coverage reports obtained from dockerized builds could need this env variables in order to use this library more easily :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant