Made further improvements in the solution per the comments below #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for this change is that the reference to the full .net version of SharpSimpleNLG library removed from SharpSimpleNLGTests and a reference to its .net standard version added.
|
Having a .net standard version of unit test library is no longer a necessity due to replacing the full .net version of SharpSimpleNLG with the .net standard version in the existing test library. Closing this PR and proceeding with the following PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a test library project in .net standard 1.6 but I could not make Nunit work in it. We can look into this non-urgent matter later on. The original test project exhibited compile issues on appveyor's CI server that I addressed it. I also added a YML file in case you'd like to get your own appveyor's account setup to have it compile this solution. Some tests do not pass in CI on appveyor, so I had to turn them off to get "passing" compile status. I also added version info and the status badge in the README markdown.