Upgrading the libraries to .net standard 1.6 and full .net 4.6.2 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded the solution to Visual Studio 2017 and all .net 4.5.2 projects switched to version 4.6.2.
|
I've merged these changes in, and published 1.2.0 onto NuGet. I hope I've done this the correct way. :-) |
|
@Arash-Sabet AND THANKS for the PR. I hope you are finding this port of the Univ of Aberdeen SimpleNLG useful. |
|
@nickhodge You are more than welcome! It’s a great and useful library and let’s keep it up-to-date as much as possible. Would you mind reflecting the newer version info in the Version News section of the markdown? Thanks. |
|
@nickhodge I just checked out this library's nuget package; I have to say that the dependencies section needs to be updated to reflect the right versions of .net. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded SharpSimpleNLG to .net standard 1.6 and created a .net core console application to test it out. The console application's code is similar to the original console application shipped in the solution. I was never able to run tests from the time when I forked the solution and since the compilation passes I assume that the tests should pass too. Please verify the changes, merge with the original master and feel free to deploy new nuget packages.