Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review back link and breadcrumb spacing and positioning #526

Closed
anandamaryon1 opened this issue Jun 20, 2024 · 1 comment
Closed

Review back link and breadcrumb spacing and positioning #526

anandamaryon1 opened this issue Jun 20, 2024 · 1 comment

Comments

@anandamaryon1
Copy link
Collaborator

What

Currently the back link component requires the use of modifier classes to add the correct margins around it. The breadcrumbs component differs in that it contains its own padding and therefore must be placed in a different location within the HTML than the back link, which is inconsistent.

Therefore, it looks like we should consider updating the two components together, updating their spacing and defining their position within the HTML. This maybe require changes to the page template guidance too.

Related issues

Back link #32
Breadcrumbs: #6
Page template: #200
nhsuk-frontend PR: nhsuk/nhsuk-frontend#964

@anandamaryon1
Copy link
Collaborator Author

Released as part of v7.0.0: nhsuk/nhsuk-service-manual#2040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant