Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabindex should not be explicitly set >0 in banner #112

Open
jeanniebrady opened this issue Jan 4, 2021 · 1 comment
Open

tabindex should not be explicitly set >0 in banner #112

jeanniebrady opened this issue Jan 4, 2021 · 1 comment

Comments

@jeanniebrady
Copy link

The generated code in cookieconsent.js results in banner html including elements with tabindex explicitly set to values greater than 0. While technically correct, these often create frustrating experiences for users who rely on assistive technology. The AXE tool flags this as a violation. Tabindex should be omitted from these elements.

@kaycee45
Copy link

kaycee45 commented Apr 9, 2021

The tabindex values greater than 0 is disrupting the tabbing order on the https://www.nhs.uk/better-health

Tabbing should Ideally work in ascending or descending order of elements within a page. However on the better health page, that is not the case. It can be confusing and frustrating for users with dyslexia or those that rely on assistive technology. The reason for this is because there is an invisible “skip to main content” link that is absolutely positioned above the cookie banner. This invisible content is only visible to screen readers or people using assistive technology, but it gets focus when tabbing.

To fix this issue and prevent such from happening on any other nhs.uk pages, I recommend setting tabindex to 0 or explicitly removing it from the buttons and links in the cookie banner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants