fix: access xhr.status after xhr.readyState becomes DONE (fix #45) (#46)

Author: heenakwag

ajax/index.js

@@ -126,9 +126,6 @@ function getComputedOptions(defaultOptions, customOptions) {
   return options;
 }
 
-var ENCODED_SPACE_REGEXP = /%20/g;
-var QS_DELIM_REGEXP = /\?/;
-
 function validateStatus(status) {
   return status >= 200 && status < 300;
 }
@@ -173,9 +170,16 @@ function parseJSONData(data) {
   return result;
 }
 
+var REQUEST_DONE = 4;
+
 function handleReadyStateChange(xhr, options) {
-  var readyState = xhr.readyState,
-      status = xhr.status,
+  var readyState = xhr.readyState;
+
+  if (readyState != REQUEST_DONE) {
+    return;
+  }
+
+  var status = xhr.status,
       statusText = xhr.statusText,
       responseText = xhr.responseText;
   var success = options.success,
@@ -184,10 +188,6 @@ function handleReadyStateChange(xhr, options) {
       reject = options.reject,
       complete = options.complete;
 
-  if (readyState != XMLHttpRequest.DONE) {
-    return;
-  }
-
   if (validateStatus(status)) {
     var contentType = xhr.getResponseHeader('Content-Type');
     var data = responseText;
@@ -215,6 +215,8 @@ function handleReadyStateChange(xhr, options) {
   });
 }
 
+var QS_DELIM_REGEXP = /\?/;
+
 function open(xhr, options) {
   var url = options.url,
       method = options.method,
@@ -259,6 +261,8 @@ function applyConfig(xhr, options) {
   xhr.setRequestHeader('x-requested-with', 'XMLHttpRequest');
 }
 
+var ENCODED_SPACE_REGEXP = /%20/g;
+
 function send(xhr, options) {
   var method = options.method,
       serializer = options.serializer,

ajax/index.mjs

@@ -160,9 +160,6 @@ function getComputedOptions(defaultOptions, customOptions) {
   return options;
 }
 
-const ENCODED_SPACE_REGEXP = /%20/g;
-const QS_DELIM_REGEXP = /\?/;
-
 function validateStatus(status) {
   return status >= 200 && status < 300;
 }
@@ -204,15 +201,19 @@ function parseJSONData(data) {
   return result;
 }
 
+const REQUEST_DONE = 4;
+
 function handleReadyStateChange(xhr, options) {
-  const { readyState, status, statusText, responseText } = xhr;
-  const { success, resolve, error, reject, complete } = options;
+  const { readyState } = xhr;
 
   // eslint-disable-next-line eqeqeq
-  if (readyState != XMLHttpRequest.DONE) {
+  if (readyState != REQUEST_DONE) {
     return;
   }
 
+  const { status, statusText, responseText } = xhr;
+  const { success, resolve, error, reject, complete } = options;
+
   if (validateStatus(status)) {
     const contentType = xhr.getResponseHeader('Content-Type');
     let data = responseText;
@@ -257,6 +258,8 @@ function handleReadyStateChange(xhr, options) {
   executeCallback(complete, { status, statusText });
 }
 
+const QS_DELIM_REGEXP = /\?/;
+
 function open(xhr, options) {
   const { url, method, serializer, params } = options;
 
@@ -298,6 +301,8 @@ function applyConfig(xhr, options) {
   xhr.setRequestHeader('x-requested-with', 'XMLHttpRequest');
 }
 
+const ENCODED_SPACE_REGEXP = /%20/g;
+
 function send(xhr, options) {
   const {
     method,