line up the menu bar

[theBreadCompany]

Hi,
first, thank you for writing this app :). It's great to have an open source (and even macOS) alternative and I really like it.

However, there is a small proposal I'd like to make: Line up the menu bar with the video.
Those paid wallpaper apps in the App Store basically do the same by loading the first frame as the wallpaper, which is good enough for wallpapers that don't drastically change their color.
I've already implemented that in a fork, but I could not test it as the Injectable package is private on their GitHub and thus not fetchable by Xcode.
Feel free to take and tweak my code, its just a proposal and not at all guaranteed to work as I could not even compile because of Injectable.

Have a nice day :).

[nhiroyasu]

Thank you for using wallpaper play.
And thank you for implementing this great feature!
Please let us incorporate it.

But, I'm sorry for keeping Injectable is private.
Changed to public so you can proceed with your development.
Feel free to update it.

Enjoy your weekend :)

[theBreadCompany]

Ok, I'm almost done implementing it, although YouTube and Websites do not work yet. It works, thumbnails are backed up at app launch and when setting a video and restored when gracefully closing the app. However, macOS seems to be a bit buggy when setting the wallpaper:

1. When you set it via System Settings and switch to a full screen application on the monitor where you just set the wallpaper, you can see that System Settings again displays the old wallpaper for that window (without actually changing it.) This hints to the issue I've also met in code:
2. When you set it in code, the same thing as above happens + the menu bar refuses to update. It really depends on whether some monitors currently display a fullscreen window.
3. Looping through the screens is not reliable. When backing up and restoring original wallpapers, it occasionally happens that only one screen is available. For now, this is handled by falling back to the last backed up wallpaper.

Here is a playground that demonstrates the System Settings bug. It changes the wallpaper, so be sure to have it handy if its not default :).

I've submitted a feedback describing all these bugs.

And a random bug in wallpaper play: Setting a video while the app is in fullscreen, the AVMediaPlayer opens up as fullscreen as well.

Please tell me when I should open a pull request.

Enjoy your weekend as well :)

[nhiroyasu]

Sorry for the delay in replying.

Thank you for finding the bugs.

I would like to open issues for the two bugs you found and look for a solution.
You can submit a pull request for the completed code now!

Thx :)