Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service): make initial translation streaming lazy #960

Merged
merged 1 commit into from
Feb 5, 2020
Merged

fix(service): make initial translation streaming lazy #960

merged 1 commit into from
Feb 5, 2020

Conversation

fjozsef
Copy link
Contributor

@fjozsef fjozsef commented Nov 13, 2018

Fixes #815

ocombe
ocombe previously approved these changes Feb 5, 2020
View reviewed changes
@ocombe
Copy link
Member

ocombe commented Feb 5, 2020

I rebased your PR onto master, but it looks like your fix doesn't work anymore :(

@fjozsef
Copy link
Contributor Author

fjozsef commented Feb 5, 2020

Apparently the newly added TranslateService.getStreamOnTranslationChange has the same issue. If you don't mind I am also going to fix that in this PR.

@ocombe
Copy link
Member

ocombe commented Feb 5, 2020

that would be awesome, thanks

@fjozsef fjozsef requested a review from ocombe February 5, 2020 16:57
@ocombe ocombe changed the title fix(TranslateService): make initial translation streaming lazy fix(service): make initial translation streaming lazy Feb 5, 2020
@ocombe ocombe merged commit 1c78cf3 into ngx-translate:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocombe ocombe ocombe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TranslateService.stream premature translation
2 participants
@fjozsef @ocombe