Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support rxjs 6.0 #816

Closed
mhosman opened this issue Mar 21, 2018 · 6 comments
Closed

Update to support rxjs 6.0 #816

mhosman opened this issue Mar 21, 2018 · 6 comments

Comments

@mhosman
Copy link

mhosman commented Mar 21, 2018

This is a forced requirement in new Angular >= 6.0 rc0

@ocombe
Copy link
Member

ocombe commented Mar 21, 2018

Actually it just need to support rxjs 5.6+, there's a document coming up soon that explains that.
I'll make the update once ngpackagr is updated to support the new Angular package format, it will probably be updated this weekend

@alvachien
Copy link

Have some issues here. As the the new material2 6.0 beta package requires angular 6.0 rc, and angular 6.0 rc requires rxjs6.0 beta.

When all beta packages installed, the project will failed at compile:
ERROR in node_modules/@ngx-translate/core/src/translate.directive.d.ts(2,10): error TS2305: Module '"C:/Users/XXX/node_modules/rxjs/Subscription"' has no exported member 'Subscription'.
node_modules/@ngx-translate/core/src/translate.loader.d.ts(1,10): error TS2305: Module '"C:/Users/XXX/node_modules/rxjs/Observable"' has no exported member 'Observable'.
node_modules/@ngx-translate/core/src/translate.service.d.ts(2,10): error TS2305: Module '"C:/Users/XXX/node_modules/rxjs/Observable"' has no exported member 'Observable'.

@ocombe ocombe closed this as completed in 152208e Mar 28, 2018
@ocombe
Copy link
Member

ocombe commented Mar 28, 2018

Version 10.0.0 has been released with support for Angular 6 and RxJS 6, can you try and tell me if it works for you?

@alvachien
Copy link

@ocombe Thanks so much for the next release.
It works! There is no more error now. Thanks!

@mhosman
Copy link
Author

mhosman commented Apr 5, 2018

Thanks for the release!!! I don't know why but since I upgraded I get Http failure response for http://localhost:4200/assets/i18n/en.json: 404 Not Found

@mhosman
Copy link
Author

mhosman commented Apr 6, 2018

Sorry, the 404 Not found is a problem with the Angular-Cli 6 RC01 and RC02, not a problem with this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants