fix(directive): always refresh value when directive params change

Fixes #423
ngx-translate · Mar 23, 2017 · c2c06bc · c2c06bc
1 parent c27e277
commit c2c06bc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/translate.directive.ts b/src/translate.directive.ts
@@ -1,6 +1,6 @@
 import {Directive, ElementRef, AfterViewChecked, Input, OnDestroy, ChangeDetectorRef} from '@angular/core';
 import {Subscription} from 'rxjs/Subscription';
-import {isDefined} from './util';
+import {equals, isDefined} from './util';
 import {TranslateService, LangChangeEvent} from './translate.service';
 import {TranslationChangeEvent} from "./translate.service";
 import {DefaultLangChangeEvent} from "./translate.service";
@@ -24,9 +24,9 @@ export class TranslateDirective implements AfterViewChecked, OnDestroy {
     }
 
     @Input() set translateParams(params: any) {
-        if(this.currentParams !== params) {
+        if(!equals(this.currentParams, params)) {
             this.currentParams = params;
-            this.checkNodes();
+            this.checkNodes(true);
         }
     }
 

diff --git a/tests/translate.directive.spec.ts b/tests/translate.directive.spec.ts
@@ -106,15 +106,18 @@ describe('TranslateDirective', () => {
     it('should update the translation when params change', () => {
         // replace the content with the key
         expect(fixture.componentInstance.withParams.nativeElement.innerHTML).toEqual('TEST');
+        expect(fixture.componentInstance.withParamsNoKey.nativeElement.innerHTML).toEqual('TEST');
 
         translate.setTranslation('en', {"TEST": "It is {{value}}"});
         translate.use('en');
 
         expect(fixture.componentInstance.withParams.nativeElement.innerHTML).toEqual('It is ok');
+        expect(fixture.componentInstance.withParamsNoKey.nativeElement.innerHTML).toEqual('It is ok');
         fixture.componentInstance.value = {value: 'changed'};
         fixture.detectChanges();
 
         expect(fixture.componentInstance.withParams.nativeElement.innerHTML).toEqual('It is changed');
+        expect(fixture.componentInstance.withParamsNoKey.nativeElement.innerHTML).toEqual('It is changed');
     });
 
     it('should update the DOM when the lang changes', () => {