Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration tool misplaces @UntilDestory() when components are annotated with a comment #113

Closed
wfairclough opened this issue Jul 14, 2020 · 5 comments

Comments

@wfairclough
Copy link

After running the migration tool on our repository the components that had comments do not add the @UntilDestory() on its own new line.

Example:

@@ -25,10 +24,10 @@ export interface DisplayInlineSupportedComponent {
 
 /**
  * Displays chslInput's value outside of host component.
- */
+ */@UntilDestroy()
 @Component({
-  selector: 'chsl-control-value-display',
-  template: `
+      selector: 'chsl-control-value-display',
+      template: `
     <div
       class="chsl-control-value-display"
       [ngClass]="{
@NetanelBasal
Copy link
Member

@arturovt @FFKL this is something we want to support?

@NetanelBasal
Copy link
Member

@wfairclough it's hard to understand what we see.

@wfairclough
Copy link
Author

Here is a screenshot instead. It is really just a small formatting problem. Not hard to manually fix either, but just thought I would mention it here.
image

@NetanelBasal
Copy link
Member

Ok, I'll leave the decision to @FFKL

@FFKL
Copy link
Contributor

FFKL commented Jul 14, 2020

@wfairclough @NetanelBasal I'll fix it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants