Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ngneat/svg-generator throws error and cannot find module 'svgo' #136

Open
var-bin opened this issue Jun 29, 2023 · 3 comments
Open

@ngneat/svg-generator throws error and cannot find module 'svgo' #136

var-bin opened this issue Jun 29, 2023 · 3 comments

Comments

@var-bin
Copy link

var-bin commented Jun 29, 2023

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

After following the installation steps from the README.md, I started using @ngneat/svg-generator via npm script command"svg": "svg-generator". I faced the following error (attached screenshot) in the terminal.

22-35-54-jb8xr

After installing svgo as a devDependency, the issue has gone

Expected behavior

No issues during the process of using @ngneat/svg-generator. svgo installs within the package

Minimal reproduction of the problem with instructions

Generate a new Angular application. Run the following commands:

  • yarn add @ngneat/svg-icon
  • yarn add @ngneat/svg-generator -D

The previous commands added the following dependencies to the package.json

{
  "dependencies": {
    "@ngneat/svg-icon": "^7.0.0",
  },
  "devDependencies": {
    "@ngneat/svg-generator": "^7.0.0",
  }
}

What is the motivation / use case for changing the behavior?

It will be great not to face the issue and get all the dependencies within the package (i.e. npm i | yarn add).

Environment


Angular version: 16.1.0


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: 16.20.1
- Platform: Mac

Others:
- Package manager: yarn
- yarn version: 1.22.0

@tbertran
Copy link

Any update on this? I'm seeing the same error.

@NetanelBasal
Copy link
Member

Is this still an issue?

@Gian-Marco-27
Copy link

any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants